Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin UI not showing error messages when deleting Issue number 4403 #4559

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Admin UI not showing error messages when deleting Issue number 4403 #4559

wants to merge 2 commits into from

Conversation

Gaurav490
Copy link

@Gaurav490 Gaurav490 commented Jan 29, 2018 •
edited
Loading

Javascript alert will be shown now whenever delete is failed.

@stennie stennie added the bug label May 29, 2018
@laurenskling
Copy link
Contributor

You are hacking into the response being empty while in 200. This is because a failed remove doesn't actually give an error status from the API.

I think we should fix this first.

@laurenskling
Copy link
Contributor

Also, you are using alert just like the remove does in other cases. I think we should look into how to transfer all these errors into the flash messages. These alerts look terrible.

@laurenskling
Copy link
Contributor

keystonejs/keystone#4832 this should actually return an error from the API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gaurav490 @laurenskling @stennie @autoboxer